Make Tiki 20 compatible with Composer 2.0
- Status
- Closed
- Subject
- Make Tiki 20 compatible with Composer 2.0
- Version
- 20.x
- Category
- Release Blocker
- Feature
- Packages
- Resolution status
- Please retest
- Submitted by
- Jonny Bradley
- Volunteered to solve
- rjsmelo
- Lastmod by
- Jonny Bradley
- Rating
- Description
Composer 2.0 requires some changes to the organisation of the packages in vendor_bundled, at the moment we are getting warnings from composer install like this:
Copy to clipboardDeprecation warning: require.Sam152/Javascript-Equal-Height-Responsive-Rows is invalid, it should not contain uppercase characters. Please use sam152/javascript-equal-height-responsive-rows instead. Make sure you fix this as Composer 2.0 will error.
which should be pretty simple to fix by changing the case of the package names, andCopy to clipboardDeprecation warning: require.jquery/plugins/colorbox is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9]([_.-]?[a-z0-9]+)*". Make sure you fix this as Composer 2.0 will error.
where we have three parts to the package, should also be ok to fix, but some may need upstream fixes which hopefully will be on their way.Another issue
Another issue is what to do about the other supported branches, 19.x, 18.x and 15.x - as they will presumably uptomatically update themselves to composer 2.0 when setup.sh is run, and then break. We need to devise a way to keep these old branches on composer 1.x.
- Solution
http://sourceforge.net/p/tikiwiki/code/70016
http://sourceforge.net/p/tikiwiki/code/70017
http://sourceforge.net/p/tikiwiki/code/70018However, see "Another issue" just above.
- Importance
- 10 high
- Easy to solve?
- 3
- Priority
- 30
- Demonstrate Bug on Tiki 19+
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show2.tiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Demonstrate Bug (older Tiki versions)
-
This bug has been demonstrated on show.tikiwiki.org
Please demonstrate your bug on show.tikiwiki.org
Show.tiki.org is not configured properlyThe public/private keys configured to connect to show.tikiwiki.org were not accepted. Please make sure you are using RSA keys. Thanks.
- Ticket ID
- 7021
- Created
- Sunday 10 February, 2019 11:35:54 UTC
by Jonny Bradley - LastModif
- Wednesday 04 September, 2019 09:36:04 UTC