Loading...
 
Skip to main content

Improve tiki-check.php

Status
Open
Subject
Improve tiki-check.php
Version
15.x
Category
  • Consistency
Feature
Administration
Resolution status
New
Submitted by
EmmArrBee
Lastmod by
EmmArrBee
Rating
(0)
Related-to
Description

In the "MySQL or MariaDB Database Properties" section, tiki-check.php appears to be agnostic about the setting of "Strict Mode" reporting the item in the "info" category.

Our experience has shown that how this value is set is very significant to TW and tiki-check should test this item and report as "good" or "ugly".

If Strict Mode reports "STRICT_TRANS_TABLES" then the tiki-check explanation is "MySQL is using strict mode."

However, in this situation tiki-stats.php fails reporting

Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'trp.tiki_pageviews.day'
which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by
The query was:
SELECT SUM(`pageviews`) AS views, `day` AS unixtime FROM `tiki_pageviews` GROUP BY FROM_UNIXTIME(`day`, '%Y-No value assignedd') ORDER BY views DESC LIMIT 1
The built query was likely:
SELECT SUM(`pageviews`) AS views, `day` AS unixtime FROM `tiki_pageviews` GROUP BY FROM_UNIXTIME(`day`, '%Y-No value assignedd') ORDER BY views DESC LIMIT 1


If mysqld.cnf is updated to include sql-mode="NO_ENGINE_SUBSTITUTION", then tiki-check shows "MySQL is not using strict mode." and tiki-stats runs without issue.

We have tested this on LTS15.5 but I note tickets 6303 reported by DNeukomm on TW16.x and 6453 reported by Bernard Sfez on TW17.x with what I suspect are related issues.

Priority
25
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6597
Created
Thursday 15 March, 2018 09:23:02 UTC
by EmmArrBee
LastModif
Thursday 15 March, 2018 10:13:30 UTC


Show PHP error messages