Loading...
 
Skip to main content

Table Builder tool always inserts a table with a single row in WYSIWYG-wiki mode

Status
Closed
Subject
Table Builder tool always inserts a table with a single row in WYSIWYG-wiki mode
Version
17.x
17.x Regression
Category
  • Regression
Feature
WYSIWYG (What You See is What You Get)
Resolution status
Fixed or Solved
Submitted by
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

The Table Builder tool offered in the toolbar when using CKEditor with wysiwyg_htmltowiki enabled inserts incorrect code in Tiki 17 and ulterior, although it worked in Tiki 16 and earlier.

For a table with "R1C1" in the first cell and "R2C1" in the first column of the second row, the inserted syntax should be...

Proper code
Copy to clipboard
||R1C1 R2C1||

...but it is actually...

Broken code
Copy to clipboard
||R1C1 %%% R2C1||


Which is to say, each newline is replaced with 3 percentage signs.

There is no change dialogTableInsert() between Tiki 16 and 17. In fact, things seem to go well in dialogTableInsert(), and even when it calls insertAt(), up to the point where insertAt() calls cked.insertText(), which is where it gets too hard to follow for me.

If the issue is in CKEditor's insertText(), it seems likely that the regression was introduced by the bump of CKeditor from 4.5.11 to 5.7 (done via r61891).

Solution
This was fixed by Jonny Bradley for Tiki 18 via r65352 .
Importance
6
Priority
30
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6522
Created
Monday 08 January, 2018 15:34:08 UTC
by Philippe Cloutier
LastModif
Monday 29 January, 2018 20:25:33 UTC


Show PHP error messages