Loading...
 

Moving a node in structure to another structure does not change structure ID of the moved node's children.

Status
Open
Subject
Moving a node in structure to another structure does not change structure ID of the moved node's children.
Version
16.x
Category
  • Release Blocker
Feature
Wiki Structure (book & table of content)
Resolution status
New
Submitted by
flamenco
Lastmod by
flamenco
Rating
(0)
Description

The method

public function move_to_structure($page_ref_id, $structure_id, $begin=true)

changes the moved node's structure_id, but not the children's structure_id. The target structure will still show the children, but will not allow them to be moved. (Pressing save will have no effect, basically causing a read-only structure, with no warnings or errors ouptut)



Here's your fix:

public function move_to_structure($page_ref_id, $structure_id, $begin=true)
        {
                $page_info = $this->s_get_page_info($page_ref_id);
                $query = "update `tiki_structures` set `pos`=`pos`-1 where `pos`>? and `parent_id`=?";
                $this->query($query, array((int) $page_info["pos"], (int) $page_info["parent_id"]));
                if ($begin) {
                        $query = "update `tiki_structures` set `pos`=`pos`+1 where `parent_id`=?";
                        $this->query($query, array($structure_id));
                        $pos = 1;
                        $query = "update `tiki_structures` set `structure_id`=?, `parent_id`=?, `pos`=? where `page_ref_id`=?";
                        $this->query($query, array($structure_id, $structure_id, $pos+1, $page_ref_id));
                } else {
                        $query = "select max(`pos`) from `tiki_structures` where `parent_id`=?";
                        $pos = $this->getOne($query, array($structure_id));
                        $query = "update `tiki_structures` set `structure_id`=?, `parent_id`=?, `pos`=? where `page_ref_id`=?";
                        $this->query($query, array($structure_id, $structure_id, $pos+1, $page_ref_id));
                }
                // get the page_ref_ids of all child pages of the moved page            
                $child_ref_ids = array();
                $result = $this->query("select child.page_ref_id from tiki_structures p inner join tiki_structures child on child.parent_id = p.page_ref_id where p.page_ref_id=" . $page_ref_id);
                while ($row = $result->fetchRow()){
                        array_push($child_ref_ids, $row['page_ref_id']);
                }
                // update the structure ids of the child pages
                $this->query("update tiki_structures set structure_id=" . $structure_id . " where page_ref_id in (" . implode(',',$child_ref_ids) . ")");
        }
Importance
10 high
Easy to solve?
5
Priority
50
Demonstrate Bug
Please demonstrate your bug on show2.tikiwiki.org

 About show2.tikiwiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.

Version: Create show2.tikiwiki.org instance
Rating (deprecated)
(0)
Ticket ID
6047
Created
Sunday 24 July, 2016 13:24:44 GMT-0000
LastModif
Sunday 24 July, 2016 14:09:29 GMT-0000

Attachments

 filenamecreatedhitscommentversionfiletype 
Screen Shot 2016-07-24 at 10.14.41 AM.png 24 Jul 16 14:15 GMT-00000SQL Output


Keywords

The following is a list of keywords that should serve as hubs for navigation within the Tiki development and should correspond to documentation keywords.

Each feature in Tiki has a wiki page which regroups all the bugs, requests for enhancements, etc. It is somewhat a form of wiki-based project management. You can also express your interest in a feature by adding it to your profile. You can also try out the Dynamic filter.

Accessibility (WAI & 508)
Accounting
Administration
Ajax
Articles & Submissions
Backlinks
Banner
Batch
BigBlueButton audio/video/chat/screensharing
Blog
Bookmark
Browser Compatibility
Calendar
Category
Chat
Comment
Communication Center
Consistency
Contacts Address book
Contact us
Content template
Contribution
Cookie
Copyright
Credits
Custom Home (and Group Home Page)
Database MySQL - MyISAM
Database MySQL - InnoDB
Date and Time
Debugger Console
Directory (of hyperlinks)
Documentation link from Tiki to doc.tiki.org (Help System)
Docs
DogFood
Draw
Dynamic Content
Preferences
Dynamic Variable
External Authentication
FAQ
Featured links
Feeds (RSS)
File Gallery
Forum
Friendship Network (Community)
Group
Help
History
Hotword
HTML Page
i18n (Multilingual, l10n, Babelfish)
Image Gallery
Import-Export
Install
Integrator
Interoperability
Inter-User Messages
InterTiki
jQuery
Kaltura video management
Karma
Live Support
Logs (system & action)
Lost edit protection
Mail-in
Map
Menu
Meta Tag
Missing features
Visual Mapping
Mobile
Mods
Modules
MultiTiki
MyTiki
Newsletter
Notepad
OS independence (Non-Linux, Windows/IIS, Mac, BSD)
Organic Groups (Self-managed Teams)
Packages
Payment
PDF
Performance Speed / Load / Compression / Cache
Permission
Poll
Profiles
Quiz
Rating
Realname
Report
Revision Approval
Scheduler
Score
Search engine optimization (SEO)
Search
Security
Semantic links
Share
Shopping Cart
Shoutbox
Site Identity
Slideshow
Smarty Template
Social Networking
Spam protection (Anti-bot CATPCHA)
Spellcheck
Spreadsheet
Staging and Approval
Stats
Survey
Syntax Highlighter (Codemirror)
Tablesorter
Tags
Task
Tell a Friend, alert + Social Bookmarking
Terms and Conditions
Theme
TikiTests
Timesheet
Token Access
Toolbar (Quicktags)
Tours
Trackers
TRIM
User Administration
User Files
User Menu
Watch
Webmail and Groupmail
WebServices
Wiki History, page rename, etc
Wiki plugins extends basic syntax
Wiki syntax text area, parser, etc
Wiki structure (book and table of content)
Workspace and perspectives
WYSIWTSN
WYSIWYCA
WYSIWYG
XMLRPC
XMPP




Useful Tools