Loading...
 
Skip to main content

Tiki banners do not allow SCRIPT elements (even with HTML purifier disabled)

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Tiki banners do not allow SCRIPT elements (even with HTML purifier disabled)
Version
12.x
15.x Regression
Category
  • Error
Feature
Banner
Resolution status
New
Submitted by
Rick Sapir / Tiki for Smarties
Lastmod by
Rick Sapir / Tiki for Smarties
Rating
(0)
Description

I want to use Tiki's banner system to manage hosted ads (such as Google Ads).

I created a new Tiki banner: tiki-edit_banner.php

In the Select ONE method for the banner: field, I selected Use HTML and added the following script (from Google Ads):

Copy to clipboard
<script type="text/javascript"><!--
google_ad_client = "ca-pub-3913918000422534";
/* Info Lettres 8 à 15 */
google_ad_slot = "8790064474";
google_ad_width = 728;
google_ad_height = 90;
//-->
</script>
<script type="text/javascript" src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
</script>


Upon saving, Tiki adds <X> to my code, breaking the SCRIPT elements:

Copy to clipboard
<script type="text/javascript"><!--
google_ad_client = "ca-pub-3913918000422534";
/* Info Lettres 8 à 15 */
google_ad_slot = "8790064474";
google_ad_width = 728;
google_ad_height = 90;
//-->
</script>
<script type="text/javascript" src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
</script>


This happens even if I HTML Purifier disabled.


Tiki should allow full HTML (including SCRIPT elements) within the HTML box for Ads. I understand the security implication of allowing SCRIPT elements, but only users with permission to create ads can do this.



I tried creating a SHOW instance, but received the following error:
Tiki Installer missing third party software files

Workaround

My workaround is to have Google Ads in a module and apply them to the pages by using the MODULE plugin. However, I can no longer:

  • Track clicks (from within Tiki)
  • Show/display the ad by time/date

Importance
8
Easy to solve?
9
Priority
72
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
6020
Created
Wednesday 06 July, 2016 13:02:25 UTC
by Rick Sapir / Tiki for Smarties
LastModif
Wednesday 06 July, 2016 13:10:47 UTC


Show PHP error messages