Loading...
 
Skip to main content

embed image out of elFinder

Status
Pending
Subject
embed image out of elFinder
Version
11.x
12.x
Category
  • Less than 30-minutes fix
  • Patch
Feature
File Gallery (elFinder or standard UI)
Wiki Plugin (extends basic syntax)
Resolution status
Please retest
Submitted by
sam91
Volunteered to solve
Jonny Bradley
Lastmod by
Jonny Bradley
Rating
(0)
Description

If you write a wiki article for example and want to insert a image or picture you already uploaded you use the button for picture.
Then you select file galleries as the data source and want to select a file directly within the file gallery.

That's not the real problem. But as soon as you use elFinder for file gallery view you still can select a image but it will always insert a whole code tag within the "image id" field (eg. ) and not only the fileid itself.


The fix is really easy, you just need to edit the file yourtikihome/templates/tiki-list_file_gallery.tpl at line 294 and replace this line with the following:

templates/tiki-list_file_gallery.tpl
Copy to clipboard
window.opener.insertAt('{{$filegals_manager}}', data.fileId);


Maybe you should fix this in a following version, as it's really annoying to fix the form every time.

---

the patch doesn't seem to work. still having the issue of the full plugin code gets injected.

This is probably a Jonny bug now since it touches ElFinder

Solution

Patch added on 12.x version.

Please check this commit id: 48348

Please check r48767, thanks (i have updated the show instance and it seems ok now, if i've fixed the right thing!)

Importance
6
Easy to solve?
10 easy
Priority
60
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
4651
Created
Thursday 15 August, 2013 15:38:21 UTC
by sam91
LastModif
Tuesday 26 November, 2013 17:55:38 UTC


Show PHP error messages