Loading...
 
Skip to main content

Plugin Approval - plugin contains {{user}} => approval required for each user

  • Tracker item actions
Trackers
Items
Status
Open
Subject
Plugin Approval - plugin contains {{user}} => approval required for each user
Version
9.x
Category
  • Usability
Feature
Wiki Plugin (extends basic syntax)
Submitted by
aytonk
Lastmod by
aytonk
Rating
(0)
Description

A plugin requires approval. The fingerprint of the plugin is recorded, and if it is already approved, another user can use the plugin (in other words can display the page which contains the plugin).

But, if the plugin contains the fragment "/{/{user/}/}", for example
{SQL(db="LOPC_XF")} SELECT `Date`, `Subject`, `From` FROM vwMessages WHERE `To` IS NULL OR `To`="/{/{user/}/}" {SQL}

then the plugin needs to be approved for each user individually.
NB - I had to put extra slashes in the above fragments to stop my username being substituted!

My guess is that the username is being substituted BEFORE the fingerprint is evaluated, which means that there is a different fingerprint for each user.

I consider that this is a bug, and that the fingerprint should be evaluated BEFORE the username is substituted, thereby allowing the plugin to be approved just once.

It ought to be a one-line fix - swap round the order of two actions - but I haven't been able to work out where in the code this fix is needed.

Importance
7
Easy to solve?
6
Priority
42
Demonstrate Bug on Tiki 19+
Demonstrate Bug (older Tiki versions)
Ticket ID
4334
Created
Saturday 03 November, 2012 15:37:02 UTC
by aytonk
LastModif
Monday 28 October, 2013 07:27:10 UTC


Show PHP error messages