Loading...
 

Headings in included pages end collapsible sections in parent page

Status
Open
Subject
Headings in included pages end collapsible sections in parent page
Category
  • Regression
Feature
Wiki Syntax (text area, parser, external wiki, etc)
Resolution status
New
Submitted by
Philippe Cloutier
Lastmod by
Philippe Cloutier
Rating
(0)
Description

Since Tiki 19, a collapsible section (generated with a heading that starts with a minus or plus sign, as documented) effectively ends at the first heading of the same level or above in the pages it includes (with the INCLUDE plugin).

For example, if page Parent has
this code
!Section 1
Direct content

!+Collapsed section
Direct content
{include page="Help"}

! Last section
Direct content

...while page Help has
the following source
!For Support Please Contact

support@company.com
(555) 123-4567

...then the "For Support Please Contact" section always shows, regardless of the toggle control's state. Clicking on "+" only reveals "Direct content".


I am categorizing this ticket in Bug::Regression because this is a regression, but this is arguably not a bug.

This issue is a regression from r66644 and therefore affects Tiki 19. That commit essentially reverted r48937 (2013-12-03, on the Tiki 12 branch), so Tiki 11 and before also have the same issue.

Note that this is the second back-and-forth on this, after r29321 was reverted by r33993.

Solution

Tiki never had any code to deal with this issue. Versions 12 to 18 were not affected by chance. Relevant code is in parse_data_process_maketoc(),

around line 2598
$aclose = '<a id="flipper' . $thisid . '" class="link" href="#" onclick="flipWithSign(\'' . $thisid . '\');return false;">[' . ($divstate == '-' ? '+' : '-') . ']</a>';
$aclose2 = '<div id="' . $thisid . '" class="showhide_heading" style="display:' . ($divstate == '+' ? 'block' : 'none') . ';">';
$headerlib = TikiLib::lib('header');
$headerlib->add_jq_onready("setheadingstate('$thisid');");
array_unshift($divdepth, $hdrlevel);
and then
around line 2568
// Close lower level divs if opened
for (; current($divdepth) >= $hdrlevel;
array_shift($divdepth)) {
	$data .= '</div>';
}
Workaround
Enabling the INCLUDE plugin's parse_included_page parameter avoids this issue.
Importance
3
Easy to solve?
1 difficult
Priority
3
Demonstrate Bug
Please demonstrate your bug on show2.tikiwiki.org

 About show2.tikiwiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.

Version: Create show2.tikiwiki.org instance
Rating (deprecated)
(1)
Ticket ID
6992
Created
Tuesday 08 January, 2019 20:03:11 GMT-0000
LastModif
Friday 11 January, 2019 17:44:54 GMT-0000

Attachments

 filenamecreatedhitscommentversionfiletype 
No attachments for this item


Keywords

The following is a list of keywords that should serve as hubs for navigation within the Tiki development and should correspond to documentation keywords.

Each feature in Tiki has a wiki page which regroups all the bugs, requests for enhancements, etc. It is somewhat a form of wiki-based project management. You can also express your interest in a feature by adding it to your profile. You can also try out the Dynamic filter.

Accessibility (WAI & 508)
Accounting
Administration
Ajax
Articles & Submissions
Backlinks
Banner
Batch
BigBlueButton audio/video/chat/screensharing
Blog
Bookmark
Browser Compatibility
Calendar
Category
Chat
Comment
Communication Center
Consistency
Contacts Address book
Contact us
Content template
Contribution
Cookie
Copyright
Credits
Custom Home (and Group Home Page)
Database MySQL - MyISAM
Database MySQL - InnoDB
Date and Time
Debugger Console
Directory (of hyperlinks)
Documentation link from Tiki to doc.tiki.org (Help System)
Docs
DogFood
Draw
Dynamic Content
Preferences
Dynamic Variable
External Authentication
FAQ
Featured links
Feeds (RSS)
File Gallery
Forum
Friendship Network (Community)
Group
Help
History
Hotword
HTML Page
i18n (Multilingual, l10n, Babelfish)
Image Gallery
Import-Export
Install
Integrator
Interoperability
Inter-User Messages
InterTiki
jQuery
Kaltura video management
Karma
Live Support
Logs (system & action)
Lost edit protection
Mail-in
Map
Menu
Meta Tag
Missing features
Visual Mapping
Mobile
Mods
Modules
MultiTiki
MyTiki
Newsletter
Notepad
OS independence (Non-Linux, Windows/IIS, Mac, BSD)
Organic Groups (Self-managed Teams)
Packages
Payment
PDF
Performance Speed / Load / Compression / Cache
Permission
Poll
Profiles
Quiz
Rating
Realname
Report
Revision Approval
Scheduler
Score
Search engine optimization (SEO)
Search
Security
Semantic links
Share
Shopping Cart
Shoutbox
Site Identity
Slideshow
Smarty Template
Social Networking
Spam protection (Anti-bot CATPCHA)
Spellcheck
Spreadsheet
Staging and Approval
Stats
Survey
Syntax Highlighter (Codemirror)
Tablesorter
Tags
Task
Tell a Friend, alert + Social Bookmarking
Terms and Conditions
Theme
TikiTests
Timesheet
Token Access
Toolbar (Quicktags)
Tours
Trackers
TRIM
User Administration
User Files
User Menu
Watch
Webmail and Groupmail
WebServices
Wiki History, page rename, etc
Wiki plugins extends basic syntax
Wiki syntax text area, parser, etc
Wiki structure (book and table of content)
Workspace and perspectives
WYSIWTSN
WYSIWYCA
WYSIWYG
XMLRPC
XMPP




Useful Tools