LDAP Authentication Broken Between Tiki 12.2 and 21.4

• Less than 30-minutes fix
• Bug

While upgrading from Tiki 12.2 to 21.4, we found that our external LDAP authentication stopped working. After turning on some debugging and looking at the code, I found this major difference between the two versions in lib/auth/ldap.php.

In 12.2 starting at line 90:
$this->options'host' = array();
foreach ($t as $h) {
if (preg_match('#^ldaps?://#', $h)) { // entry is already URI
$this->options'host'[] = $h;
} else {
$this->options'host'[] = $prefix . $h . ':' . $port;
}
}

In 21.4 starting at line 96:
$this->options'host' = [];
foreach ($t as $h) {
if (preg_match('#^ldaps?://#', $h)) { // entry is already URI
$this->options'host' = $h;
} else {
$this->options'host' = $h;
}
}

Note that in 21.4 regardless of result of the if, the executed code is the same and the LDAP connection will fail if the "host" is not in URI format. I believe the else clause should look similar to that from 12.2. A workaround is to enter a full URI in the configuration for the LDAP server host.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org