Nonsensical (at first look) "translation" of icons
- Status
- Open
- Subject
- Nonsensical (at first look) "translation" of icons
- Version
- 18.x
21.x Regression - Category
- Error
- Less than 30-minutes fix
- Easy for Newbie Dev
- Feature
- Toolbars, Quicktags and Smileys
- Resolution status
- New
- Submitted by
- hman
- Lastmod by
- hman
- Rating
- Description
In /lib/toolbars/toolbarslib.php several calls for icon FILES get translated. Why would the file names or paths of icon files be translated?
This is just a (very) minor issue, but unnecessarily inflates language.php in all target languages. Example:
switch ($tagName) { case 'bold': $label = tra('Bold'); $icon = tra('img/icons/text_bold.png'); $iconname = 'bold'; $wysiwyg = 'Bold'; $syntax = '__text__'; break;With this, a translator could exchange toolbar icons (or their paths) in his/her translation. But what would be the use case for that? 22 icon file names are pumped through tra() in total... Maybe there is some deeper logic, but I don't get it ;-)
- Importance
- 1 low
- Easy to solve?
- 10 easy
- Priority
- 10
- Demonstrate Bug (Tiki 19+)
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Version: Create show2.tiki.org instanceAbout show2.tiki.orgTo help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.
- Ticket ID
- 7723
- Created
- Saturday 10 April, 2021 20:30:35 GMT-0000
by hman - LastModif
- Monday 15 August, 2022 13:29:15 GMT-0000
Attachments
| filename | created | hits | comment | version | filetype | ||
|---|---|---|---|---|---|---|---|
| No attachments for this item | |||||||
;){kind=link}
;){kind=link}
- Feature request: Be able to exclude (by category) the pages listed in Latest Changes module
- Add a command to console.php to invalidate certain objects in the search index
- Counting items in Items List Doesn't Work due to lack of , between items
- Modals in Quartz theme are too narrow
- Tracker Currency Field not working
;){kind=link}
;){kind=link}