Improving PDF TOCs with large wiki documents using mix of TOC and MAKETOC

• Patch

I do not know how to contribute code, but have developed the following "fix" that works to create TOCs when using the >Print Current Document feature in TW. This fixes the problem with the TOC growing to enormous length on a large page with each new section TOC being appended to the previous section's TOC. This fix has worked across many major versions.

File: tikiwiki/lib/parser/parserlib.php
Insertion point: in 12.0 line 2814; in 12.2 line 2967

Insert IMMEDIATELY BEFORE the following existing code:

if (!empty($maketoc)) {
		$maketoc = $maketoc_header.$maketoc.$maketoc_footer;
					}

Inserted code:

//=====larryg  -- beginning of custom code to make TOC and MAKETOC work properly in tandem
					global $TOC_newstring, $TOC_oldstring ;
				
					$TOC_newstring = $maketoc ; //===== get a copy of the newest TOC before we do anything to it
        			if ( strpos($maketoc, $TOC_oldstring) ) // larryg - if this MAKETOC contains previous chapter's TOC entries, remove that portion of the string
					{
						$maketoc = substr($maketoc, 0 , strpos($maketoc, $TOC_oldstring)).substr($maketoc, strpos($maketoc, $TOC_oldstring)+ strlen($TOC_oldstring)) ; 
					}
  			  			
					//prepare this chapter's TOC entry to be compared with the next chapter's string]
					$head_string = '<li><a href='   ;
					$tail_string = '<!--toc-->' ; 
					if ( strpos($TOC_newstring, $head_string ) && strpos($TOC_newstring, $tail_string) ) { 
						$TOC_newstring = substr($TOC_newstring, strpos($TOC_newstring, $head_string) ) ; // trim unwanted stuff from the beginning of the string
					//        	$maketoc_header = 'PRESTRINGFOUND'.$maketoc_header ;
						$TOC_newstring = substr($TOC_newstring, 0, (strpos($TOC_newstring, $tail_string) -5)) ; // trim the stuff from the tail of the string    </ul></li></ul>
					//          $maketoc_footer = 'POSTRINGFOUND' ;
						$TOC_oldstring = $TOC_newstring ;
					}
//=====larryg  -- end of custom code for TOC and MAKETOC

Please feel free to apply/use as you see appropriate,

-larryg

This bug has been demonstrated on show2.tikiwiki.org

Please demonstrate your bug on show2.tikiwiki.org