Setup: Running 6.4, on Debian. Recently upgraded from 3.x, bug was present in previous version too.
1. In our TikiWiki forums, all discussion is emailed to an external address
2. At the footer of each email message, the Tiki appends a "Reply Link".
3. When a user receives the notification email, and follows the link, the Forum's "Reply to the selected post" fields are incorrectly populated. The "Title" field is for an enitrely different forum + thread, and the reply box contents are also not correct.
Subjectively (not exhaustively tested), this appears to only happen for posts after the first within a thread, e.g. the reply link for the original post functions correctly, but reply link for all following posts does not.
The 'correct' top post reply links are in the form:
<host>/tiki/tiki-view_forum_thread.php?forumId=14&comments_parentId=2994#form
While the 'incorrect' reply posts are:
<host>/tiki/tiki-view_forum_thread.php?forumId=14&comments_reply_threadId=14&comments_parentId=2994&post_reply=1#form
I suspect reply_threadId may be improperly populated with the forumId.
Thanks in advance.
It looked like the code for 7.2 (STABLE) was also affected.
For 6.4, in tiki/lib/comments/commentslib.php, line 2615, I modified the call into sendForumEmailNotification. The second argument is fixed as $params'forumId', but I believe that is only accurate when notifying of a new topic. To cover subsequent posts, I modified the second argument to
empty($params'comments_reply_threadId')? $params'forumId' : $threadId
To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.
To help developers solve the bug, we kindly request that you demonstrate your bug on a show.tikiwiki.org instance. To start, simply select a version and click on "Create show.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show.tikiwiki.org.
filename | created | hits | comment | version | filetype | ||
---|---|---|---|---|---|---|---|
No attachments for this item |