Renaming or creation of pages with brackets in name not updating links when Wysiwyg
- Status
- Pending
- Subject
- Renaming or creation of pages with brackets in name not updating links when Wysiwyg
- Version
- 6.x
- Category
- Error
- Feature
- Wiki (page view, edit, history, rename, etc)
WYSIWYG (What You See is What You Get) - Submitted by
- Nelson Ko
- Lastmod by
- Arild Berg
- Rating
- Description
Renaming or creation of pages with brackets in name not updating links when Wysiwyg.
Affects both ? and normal links.
- Solution
Will commit this once 6.0 release is done.
Index: lib/wiki/wikilib.php =================================================================== --- lib/wiki/wikilib.php (revision 30521) +++ lib/wiki/wikilib.php (working copy) @@ -214,12 +214,20 @@ $data = preg_replace("/(?<=\(\()$quotedOldName(?=\)\)|\|)/i", $newName, $data); $quotedOldHtmlName = preg_quote( urlencode($oldName), '/' ); + // Need to set %28 and %29 back to brackets for wysiwyg + $quotedOldHtmlName2 = $quotedOldHtmlName; + $quotedOldHtmlName2 = str_replace('%28', '\(', $quotedOldHtmlName2); + $quotedOldHtmlName2 = str_replace('%29', '\)', $quotedOldHtmlName2); + $htmlSearch = '/<a class="wiki" href="tiki-index\.php\?page=' . $quotedOldHtmlName . '([^"]*)"/i'; + $htmlSearch2 = '/<a class="wiki" href="tiki-index\.php\?page=' . $quotedOldHtmlName2 . '([^"]*)"/i'; $htmlReplace = '<a class="wiki" href="tiki-index.php?page=' . urlencode($newName) . '\\1"'; $data = preg_replace($htmlSearch, $htmlReplace, $data); - + $data = preg_replace($htmlSearch2, $htmlReplace, $data); $htmlWantedSearch = '/(' . $quotedOldName . ')?<a class="wiki wikinew" href="tiki-editpage\.php\?page=' . $quotedOldHtmlName . '"[^<]+<\/a>/i'; + $htmlWantedSearch2 = '/(' . $quotedOldName . ')?<a class="wiki wikinew" href="tiki-editpage\.php\?page=' . $quotedOldHtmlName2 . '"[^<]+<\/a>/i'; $data = preg_replace($htmlWantedSearch, '((' . $newName . '))', $data); + $data = preg_replace($htmlWantedSearch2, '((' . $newName . '))', $data); if ($is_wiki_page) { $query = "update `tiki_pages` set `data`=?,`page_size`=? where `pageName`=?";- Importance
- 8
- Priority
- 40
- Demonstrate Bug (Tiki 19+)
-
This bug has been demonstrated on show2.tikiwiki.org
Please demonstrate your bug on show2.tikiwiki.org
Version: Create show2.tikiwiki.org instanceAbout show2.tikiwiki.orgTo help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.
- Ticket ID
- 3630
- Created
- Tuesday 09 November, 2010 23:32:06 GMT-0000
by Nelson Ko - LastModif
- Saturday 08 October, 2011 03:45:13 GMT-0000
Attachments
| filename | created | hits | comment | version | filetype | ||
|---|---|---|---|---|---|---|---|
| No attachments for this item | |||||||
;){kind=link}
;){kind=link}
- Fixed Top Menu (Classic bootstrap) and bottom modules are lost when using the Admin new UI (Tiki23 default)
- Plugin Convene: Extend the deadline if there's a tie
- Changed names of custom modules will create a new custom
- Wrong generated link from category links.
- We can't open the modals multiple times on a Wiki page in edit mode
;){kind=link}
;){kind=link}