check_feature fields missing from tables when upgrading fom 2.1 to 5

• Error
• Regression
• Consistency

When running the upgrade using tiki-install.php to upgrade from 2.1 to 5 33 database errors are reported. Several of these are "Unknown column 'feature_check' in 'field list'" errors.

During an upgrade, it is normal to have SQL failures resulting with Table already exists messages.

20091105_auth_tokens_tiki
-- 2009-11-05 lphuberdeau CREATE TABLE `tiki_auth_tokens` ( `tokenId` INT NOT NULL AUTO_INCREMENT, `creation` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, `timeout` INT NOT NULL DEFAULT 0, `token` CHAR(32), `entry` VARCHAR(50), `parameters` VARCHAR(255), `groups` VARCHAR(255), PRIMARY KEY( `tokenId` ), KEY `tiki_auth_tokens_token` (`token`) ) Table 'tiki_auth_tokens' already exists

20091123_dns_permission_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_dsn_query', 'Can execute arbitrary queries on a given DSN', 'admin', 'dsn', NULL, NULL) Unknown column 'feature_check' in 'field list'

20091124_fgal_backlink_tiki
CREATE TABLE `tiki_file_backlinks` ( `fileId` int(14) NOT NULL, `objectId` int(12) NOT NULL, KEY `objectId` (`objectId`), KEY `fileId` (`fileId`) ); Table 'tiki_file_backlinks' already exists

20091204_tiki_p_view_newsletter_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_view_newsletter', 'Can view the archive of a newsletters', 'basic', 'newsletters', NULL, 'feature_newsletters') Unknown column 'feature_check' in 'field list'

20091214_perspective_management_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_perspective_edit', 'Can edit the perspective', 'admin', 'perspective', NULL, 'feature_perspective') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_perspective_create', 'Can create a perspective', 'admin', 'perspective', NULL, 'feature_perspective') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_perspective_admin', 'Can admin perspectives', 'admin', 'perspective', 'y', 'feature_perspective') Unknown column 'feature_check' in 'field list'

20100107_payment_tiki
CREATE TABLE `tiki_payment_requests` ( `paymentRequestId` INT NOT NULL AUTO_INCREMENT, `amount` DECIMAL(7,2) NOT NULL, `amount_paid` DECIMAL(7,2) NOT NULL DEFAULT 0.0, `currency` CHAR(3) NOT NULL, `request_date` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, `due_date` TIMESTAMP NOT NULL, `cancel_date` TIMESTAMP NULL, `description` VARCHAR(100) NOT NULL, `actions` TEXT, PRIMARY KEY( `paymentRequestId` ) ) Table 'tiki_payment_requests' already exists CREATE TABLE `tiki_payment_received` ( `paymentReceivedId` INT NOT NULL AUTO_INCREMENT, `paymentRequestId` INT NOT NULL, `payment_date` TIMESTAMP DEFAULT CURRENT_TIMESTAMP, `amount` DECIMAL(7,2), `type` VARCHAR(15), `details` TEXT, PRIMARY KEY(`paymentReceivedId`), KEY `payment_request_ix` (`paymentRequestId`) ) Table 'tiki_payment_received' already exists INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_payment_admin', 'Can administer payments', 'admin', 'payment', 'y', 'payment_feature') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_payment_view', 'Can view payment requests and details', 'admin', 'payment', NULL, 'payment_feature') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_payment_manual', 'Can enter manual payments', 'admin', 'payment', NULL, 'payment_feature') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_payment_request', 'Can request a payment', 'admin', 'payment', NULL, 'payment_feature') Unknown column 'feature_check' in 'field list'

20100115_tiki_p_admin_modules_tiki
INSERT INTO users_permissions (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES ('tiki_p_admin_modules', 'User can Administer Modules', 'registered', 'tiki', NULL, NULL) Unknown column 'feature_check' in 'field list'

20100128_tiki_p_blog_view_ref_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_blog_post_view_ref', 'Can view in module and feed the blog posts', 'basic', 'blogs', NULL, 'feature_blogs') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_blog_view_ref', 'Can view in module and feed the blog', 'basic', 'blogs', NULL, 'feature_blogs') Unknown column 'feature_check' in 'field list'

20100203_payment_detail_tiki
ALTER TABLE tiki_payment_requests ADD COLUMN detail TEXT Duplicate column name 'detail'

20100205_tiki_p_wiki_view_ref_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_wiki_view_ref', 'Can view in module and feed the wiki pages reference', 'basic', 'wiki', NULL, 'feature_wiki') Unknown column 'feature_check' in 'field list'

20100211_rss_items_tiki
CREATE TABLE `tiki_rss_items` ( `rssItemId` INT NOT NULL AUTO_INCREMENT PRIMARY KEY, `rssId` INT NOT NULL, `guid` VARCHAR(255) NOT NULL, `url` VARCHAR(255) NOT NULL, `publication_date` INT UNSIGNED NOT NULL, `title` VARCHAR(255) NOT NULL, `author` VARCHAR(255), `description` TEXT, `content` TEXT, KEY `tiki_rss_items_rss` (`rssId`), UNIQUE `tiki_rss_items_item` (`rssId`, `guid`) ) Table 'tiki_rss_items' already exists ALTER TABLE `tiki_rss_modules` DROP COLUMN `content` Can't DROP 'content'; check that column/key exists ALTER TABLE `tiki_rss_modules` ADD COLUMN `sitetitle` VARCHAR(255) Duplicate column name 'sitetitle' ALTER TABLE `tiki_rss_modules` ADD COLUMN `siteurl` VARCHAR(255) Duplicate column name 'siteurl'

20100215_create_tiki_user_login_cookies_tiki
CREATE TABLE `tiki_user_login_cookies` ( `userId` INT NOT NULL, `secret` CHAR(64) NOT NULL, `expiration` TIMESTAMP NOT NULL, PRIMARY KEY (`userId`, `secret`) ) ENGINE=MyISAM AUTO_INCREMENT=1 Table 'tiki_user_login_cookies' already exists

20100215_rating_permissions_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_rate_article', 'Can rate articles', 'basic', 'cms', NULL, 'feature_articles') Unknown column 'feature_check' in 'field list'

20100216_attributes_tiki
CREATE TABLE `tiki_object_attributes` ( `attributeId` INT PRIMARY KEY AUTO_INCREMENT, `type` varchar(50) NOT NULL, `itemId` varchar(255) NOT NULL, `attribute` varchar(25) NOT NULL, `value` varchar(100), UNIQUE `item_attribute_uq` ( `type`, `itemId`, `attribute` ), KEY `attribute_lookup_ix` (`attribute`, `value`) ) Table 'tiki_object_attributes' already exists

20100217_rating_config_tiki
CREATE TABLE `tiki_rating_configs` ( `ratingConfigId` INT PRIMARY KEY AUTO_INCREMENT, `name` VARCHAR(50) NOT NULL, `expiry` INT NOT NULL DEFAULT 3600, `formula` TEXT NOT NULL, `callbacks` TEXT ) Table 'tiki_rating_configs' already exists CREATE TABLE `tiki_rating_obtained` ( `ratingId` INT PRIMARY KEY AUTO_INCREMENT, `ratingConfigId` INT NOT NULL, `type` VARCHAR(50) NOT NULL, `object` INT NOT NULL, `expire` INT NOT NULL, `value` FLOAT NOT NULL, UNIQUE `tiki_obtained_rating_uq` (`type`, `object`, `ratingConfigId`) ) Table 'tiki_rating_obtained' already exists

20100218_auth_token_reuse_tiki
ALTER TABLE `tiki_auth_tokens` ADD COLUMN `hits` INT NOT NULL DEFAULT 1 AFTER `timeout` Duplicate column name 'hits'

20100224_object_relations_tiki
CREATE TABLE `tiki_object_relations` ( `relationId` INT PRIMARY KEY AUTO_INCREMENT, `relation` varchar(25) NOT NULL, `source_type` varchar(50) NOT NULL, `source_itemId` varchar(255) NOT NULL, `target_type` varchar(50) NOT NULL, `target_itemId` varchar(255) NOT NULL, KEY `relation_source_ix` (`source_type`, `source_itemId`), KEY `relation_target_ix` (`target_type`, `target_itemId`) ) Table 'tiki_object_relations' already exists

20100226_tracker_dump_perm_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_tracker_dump', 'Can save a CSV backup of entire trackers', 'admin', 'trackers', NULL, 'feature_trackers') Unknown column 'feature_check' in 'field list'

20100419_bigbluebutton_tiki
INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_bigbluebutton_join', 'Can join a meeting', 'basic', 'bigbluebutton', NULL, 'bigbluebutton_feature') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_bigbluebutton_moderate', 'Can moderate a meeting', 'admin', 'bigbluebutton', NULL, 'bigbluebutton_feature') Unknown column 'feature_check' in 'field list' INSERT INTO `users_permissions` (`permName`, `permDesc`, `level`, `type`, `admin`, `feature_check`) VALUES('tiki_p_bigbluebutton_create', 'Can create a meeting', 'admin', 'bigbluebutton', NULL, 'bigbluebutton_feature') Unknown column 'feature_check' in 'field list'

If you think that the errors of a patch can be ignored, please check the checkbox associated to it before clicking on continue.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org