Tried fixing it properly but the attempt failed. See svn diff below. Anyway, commenting the perm check out, plus adding the other minor fixes worksaround (but essentially disables perm checking for filtering the list).
Index: lib/rankings/ranklib.php =================================================================== --- lib/rankings/ranklib.php (revision 26060) +++ lib/rankings/ranklib.php (working copy) @@ -155,13 +155,14 @@ $count = 0; $ret = array(); $result = $commentslib->get_all_comments( 'forum', 0, $limit, 'commentDate_desc' ); - $result['data'] = Perms::filter( array( 'type' => 'forum' ), 'object', $result['data'], array( 'object' => 'forumId', 'forum_read' ) ); + // tried this -> changing forumId to object but did not work + //$result['data'] = Perms::filter( array( 'type' => 'forum' ), 'object', $result['data'], array( 'object' => 'object', 'forum_read' ) ); foreach( $result['data'] as $res ) { - $aux['name'] = $res['name'] . ': ' . $res['title']; + $aux['name'] = $res['title']; // removed the preceding 'name' as it is not is the query $aux['title'] = $res['title']; $tmp = $res['parentId']; if ($tmp == 0) $tmp = $res['threadId']; - $aux['href'] = 'tiki-view_forum_thread.php?forumId=' . $res['forumId'] . '&comments_parentId=' . $tmp; + $aux['href'] = 'tiki-view_forum_thread.php?forumId=' . $res['object'] . '&comments_parentId=' . $tmp; $aux['hits'] = $this->get_long_datetime($res['commentDate']); $tmp = $res['parentId']; if ($tmp == 0) $tmp = $res['threadId'];
To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.
Unable to connect to show.tikiwiki.org. Please let us know of the problem so that we can do something about it. Thanks.
filename | created | hits | comment | version | filetype | ||
---|---|---|---|---|---|---|---|
No attachments for this item |