Watch structures from wiki pages - permission denied

• Error
• Patch

When on a wiki page on my tiki, I have the options available to watch the specific page or to "Monitor the sub-structure". When clicking on the latter, I am redirected to a permission denied page and the watch for the sub-structure is not set.

Even admin is being denied the permission to set a sub-structure watch on a wiki page.

Setting a watch on a sub-structure inside the structure-admin menu works fine for any permitted, though.

On version 4.1 the following code can be found in tiki-index.php line number 411:

if (($_REQUEST['watch_action'] == 'add_desc' || $_REQUEST['watch_action'] == 'remove_desc') && $objectperms->watch_structure ) {
			$access->display_error( $page, tra('Permission denied'), '403');
		}

If i am not mistaken, $objectperms->watch_structure should return true, if the rights are given to watch the structure. So having the rights AND requesting a watch will result in permission denied, which is basicly the opposite of the intended.

The following code works for me an should be the appropriate fix (as mentioned, if I am not mistaken).

if (($_REQUEST['watch_action'] == 'add_desc' || $_REQUEST['watch_action'] == 'remove_desc') && !$objectperms->watch_structure ) {
			$access->display_error( $page, tra('Permission denied'), '403');
		}

$objectperms->watch_structure simply negated.

This bug has been demonstrated on show2.tiki.org

Please demonstrate your bug on show2.tiki.org