Calendar item start/end hour selection is broken in Tikiwiki 2.0 using PHP 4.3.2 or previous - Patch
- Status
- Pending
- Subject
- Calendar item start/end hour selection is broken in Tikiwiki 2.0 using PHP 4.3.2 or previous - Patch
- Version
- 2.x
- Category
- Patch
- Feature
- Calendar
- Submitted by
- sacra
- Lastmod by
- sacra
- Rating
- Description
On TikiWiki 2.0, when adding or editing events in a <span class= "highlight_word_0">calendar</span>, if you're using PHP 4.3.2 or previous, you will only be allowed to choose 0, 1 or 2 as the <span class= "highlight_word_1">start</span>/<span class= "highlight_word_2">end</span> hour, even if the <span class= "highlight_word_0">calendar</span> is configured to offer 0-23 or something along those lines.
This is because of the following line in the file $TW_HOME/lib/smarty_tiki/function.html_select_time.php:
Copy to clipboard$hours = $use_24_hours ? range($hour_min, $hour_max) : range(1, 12);
The range function, as explained here (see ChangeLog), in PHP versions previous to 4.3.2 inclusive, treats numeric strings as strings and not integers which <span class= "highlight_word_2">end</span>s up meaning that "23" is seen as "2", hence producing the problem.- Solution
For example, replace the line by:
Copy to clipboard$hours = $use_24_hours ? range((int)$hour_min, (int)$hour_max) : range(1, 12);- Importance
- 3
- Priority
- 15
- Demonstrate Bug (Tiki 19+)
-
This bug has been demonstrated on show2.tiki.org
Please demonstrate your bug on show2.tiki.org
Version: Create show2.tiki.org instanceAbout show2.tiki.orgTo help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tiki.org instance. To start, simply select a version and click on "Create show2.tiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tiki.org.
- Ticket ID
- 1993
- Created
- Thursday 28 August, 2008 13:13:32 GMT-0000
by Unknown - LastModif
- Thursday 28 August, 2008 14:09:28 GMT-0000
;){kind=link}
;){kind=link}
- Structures, Wiki pages; It should not be possible to create a page through structure with an "illegal" name
- Daily build zip file for Tiki26 is not available (404)
- htaccess.sh is gone from Tiki26 and after the installation you may need to create the symlink manually
- Create new Group function does not work Tiki V26.0 Clean install brand new database
- Manticore install and configuration
;){kind=link}
;){kind=link}