Guidelines for Merge Request reviewers

Here are the merge requests: https://gitlab.com/groups/tikiwiki/-/merge_requests

• Ready to be merged: https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&draft=no
• Not ready to be merged (in draft): https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&draft=yes

Main reviewers

• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=marclaporte
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=adrienmaloba
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=kroky
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=gary.cunningham-lee
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=jonnybradley
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=luciash
• https://gitlab.com/groups/tikiwiki/-/merge_requests?scope=all&state=opened&reviewer_username=robertokir

Guidelines

• If a MR is in draft, you can provide feedback, but don't merge yet.

Continuous integration pipeline

In general, do not merge if there are failing tests, but as of 2023-02-01, we have some issues on older branches, so pipeline will run tests only on modified files in MR/commit

Status as of 2023-02-01:

• https://gitlab.com/tikiwiki/tiki/-/commits/master Runs tests on all files (even files you don't modify)
• https://gitlab.com/tikiwiki/tiki/-/commits/25.x Runs tests only on modified files in MR/commit
• https://gitlab.com/tikiwiki/tiki/-/commits/24.x Runs tests only on modified files in MR/commit
• https://gitlab.com/tikiwiki/tiki/-/commits/21.x Runs tests only on modified files in MR/commit
• https://gitlab.com/tikiwiki/tiki/-/commits/18.x Runs tests only on modified files in MR/commit

What to review

• Does this make sense in Tiki? (reviewers are experienced with Tiki)
  • Does it duplicate functionality?
  • If a new library was added: How to pick a software library
  • Will it break things for current users?
• Code quality
  • Is the code quality higher than the average in Tiki?
  • Is there some copy-pasted code?
  • As Victor wrote: "code reviewers usually do code quality review and note specific areas to improve but we are not compilers. You have to test every place of code you touch before committing."