Loading...
 

Lots of wrongly escaped quotes in /lib/prefs/feature.php

Status
Open
Subject
Lots of wrongly escaped quotes in /lib/prefs/feature.php
Version
18.x
Category
  • Usability
  • Less than 30-minutes fix
  • Bug
  • Easy for Newbie Dev
Feature
Admin Interface (UI)
Resolution status
New
Submitted by
hman
Lastmod by
hman
Rating
(0)
Description

/lib/prefs/feature.php contains 11 instances of quote characters that are wrongly escaped. To my understanding of PHP they shouldn't be escaped with a backslash if they are in single quote strings, which they are.

Example:

'feature_jquery_zoom' => [
			'name' => tra('jQuery zoom'),
			'description' => tra('Enables zoom in images on mouseover or click. Used in Plugin Img with the parameter \"thumb=zoombox\"'),
			'type' => 'flag',
			'help' => 'PluginImg#Zoombox',
			'default' => 'n',
		],


The description string is enclosed in single quotes, yet the double quotes that are part of the string were escaped with backslashes. And the strings are fed into tra().

This leads to the backslashes being visible to the user in English language, and making translating really hard: The only way that tra() will catch these with a content from custom.php is double escaping like this:

"Enables zoom in images on mouseover or click. Used in Plugin Img with the parameter \\\"thumb=zoombox\\\"" => "Emöglicht, in Bilder hineinzuzoomen bei Mouseover oder Klick. Im Img-Plugin mit dem Parameter \"thumb=zoombox\" verwendet",


I'm not sure if many writers of other translations out there know about this implication...

Not all strings in feature.php have been escaped like this, actually there are 11 instances of \" in there. Some, actually many, strings were written the right way like this example:

'feature_jquery_reflection' => [
			'name' => tra('Reflection'),
			'description' => tra('Creates a reflection under an image. Used in Plugin Img with the parameter "class=reflect"'),
			'type' => 'flag',
			'help' => 'JQuery#Reflection',
			'default' => 'n',		// reflection effects on images
		],


The 11 instances are on lines 1526 (2), 1841 (2), 2084 (2), 2191 (2), 2928 (2). Line 2496 uses \" for something else.

Importance
5
Easy to solve?
10 easy
Priority
50
Demonstrate Bug (Tiki 19+)
Please demonstrate your bug on show2.tikiwiki.org
 About show2.tikiwiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.

Version: Create show2.tikiwiki.org instance
Ticket ID
7431
Created
Tuesday 21 July, 2020 22:57:48 GMT-0000
LastModif
Tuesday 21 July, 2020 23:33:30 GMT-0000

Attachments

 filenamecreatedhitscommentversionfiletype 
No attachments for this item


Keywords

The following is a list of keywords that should serve as hubs for navigation within the Tiki development and should correspond to documentation keywords.

Each feature in Tiki has a wiki page which regroups all the bugs, requests for enhancements, etc. It is somewhat a form of wiki-based project management. You can also express your interest in a feature by adding it to your profile. You can also try out the Dynamic filter.

Accessibility (WAI & 508)
Accounting
Administration
Ajax
Articles & Submissions
Backlinks
Banner
Batch
BigBlueButton audio/video/chat/screensharing
Blog
Bookmark
Browser Compatibility
Calendar
Category
Chat
Comment
Communication Center
Consistency
Contacts Address book
Contact us
Content template
Contribution
Cookie
Copyright
Credits
Custom Home (and Group Home Page)
Database MySQL - MyISAM
Database MySQL - InnoDB
Date and Time
Debugger Console
Diagram
Directory (of hyperlinks)
Documentation link from Tiki to doc.tiki.org (Help System)
Docs
DogFood
Draw -superseded by Diagram
Dynamic Content
Preferences
Dynamic Variable
External Authentication
FAQ
Featured links
Feeds (RSS)
File Gallery
Forum
Friendship Network (Community)
Gantt
Group
Groupmail
Help
History
Hotword
HTML Page
i18n (Multilingual, l10n, Babelfish)
Image Gallery
Import-Export
Install
Integrator
Interoperability
Inter-User Messages
InterTiki
jQuery
Kaltura video management
Karma
Live Support
Logs (system & action)
Lost edit protection
Mail-in
Map
Menu
Meta Tag
Missing features
Visual Mapping
Mobile
Mods
Modules
MultiTiki
MyTiki
Newsletter
Notepad
OS independence (Non-Linux, Windows/IIS, Mac, BSD)
Organic Groups (Self-managed Teams)
Packages
Payment
PDF
Performance Speed / Load / Compression / Cache
Permission
Poll
Profiles
Quiz
Rating
Realname
Report
Revision Approval
Scheduler
Score
Search engine optimization (SEO)
Search
Security
Semantic links
Share
Shopping Cart
Shoutbox
Site Identity
Slideshow
Smarty Template
Social Networking
Spam protection (Anti-bot CATPCHA)
Spellcheck
Spreadsheet
Staging and Approval
Stats
Survey
Syntax Highlighter (Codemirror)
Tablesorter
Tags
Task
Tell a Friend
Terms and Conditions
Theme
TikiTests
Timesheet
Token Access
Toolbar (Quicktags)
Tours
Trackers
TRIM
User Administration
User Files
User Menu
Watch
Webmail and Groupmail
WebServices
Wiki History, page rename, etc
Wiki plugins extends basic syntax
Wiki syntax text area, parser, etc
Wiki structure (book and table of content)
Workspace and perspectives
WYSIWTSN
WYSIWYCA
WYSIWYG
XMLRPC
XMPP




Useful Tools