Loading...
 

13.x: Forum Thread Rating doesn't display icons for value 0, wrong icon for value 1, and no icons when labels are set beyond values

Status
Closed
Subject
13.x: Forum Thread Rating doesn't display icons for value 0, wrong icon for value 1, and no icons when labels are set beyond values
Version
13.x
Category
  • Error
  • Usability
Feature
All / Undefined
Forum
Rating
Edit interface (UI)
Deliberation
Resolution status
Fixed
Submitted by
Xavier de Pedro
Lastmod by
Xavier de Pedro
Rating
(1)
Description

13.x: Forum Thread Rating doesn't display icons for value 0, wrong icon for value 1 (fixed) , and no icons when labels are set beyond values (unfixed still)

I have it reproduced reusing the show instance of this other bug report:
https://dev.tiki.org/item5253
(linked here in case I need to go there to "svn up" again)

See this thread started by admin:
http://xavi-9794-5253.show.tikiwiki.org/tiki-view_forum_thread.php?comments_parentId=1

admin:
u: admin
p: 12345

Log in as user1
u: user1
p: user1


And here you can see a screenshot of the issue reproduced similarly in local:

2 815


With these values in Wiki rating options:

0=foo,1=bar,2=bar2,3=bar3,4=bar4,5=bar5
Solution

Hi Gezza,
The issue is due to the foreach array value, Because there is no key is used to store the values in array and display it the option is directly used. Now i fixed it by giving key values.

Please refer the commit Id :51666

Thanks


Fix confirmed. Thanks!

Workaround

note: mani is working on a fix

gezzaz note: I also took a look, maybe you find my findings useful. Problem seems to be with function get_options_smiles in lib/rating/ratinglib.php

When you set a name (text) for rating options, confusion comes as numbers are expected on some places.

foreach ($options as $key => &$option) {
			$optionsAsKeysSorted[$option] = $key;
		}
		unset($key);
		ksort($optionsAsKeysSorted);

		$sets = $this->get_options_smiles_id_sets();
		$set = $sets[count($options)];

		foreach ($optionsAsKeysSorted as $key => &$option) {
			$option = array(
				'img' => 'img/rating_smiles/' . $option . '.png',
				'color' => $colors[$option]
			);
		}

this seems to work for me, but also in rating.tpl you need to change the key and value in the foreach when rating_smileys pref is on.

There might be some conceptual confusion here when having text as rating values, I could not get further yet.

Importance
5
Easy to solve?
5
Priority
25
Demonstrate Bug
Please demonstrate your bug on show2.tikiwiki.org

 About show2.tikiwiki.org

To help developers solve the bug, we kindly request that you demonstrate your bug on a show2.tikiwiki.org instance. To start, simply select a version and click on "Create show2.tikiwiki.org instance". Once the instance is ready (in a minute or two), as indicated in the status window below, you can then access that instance, login (the initial admin username/password is "admin") and configure the Tiki to demonstrate your bug. Priority will be given to bugs that have been demonstrated on show2.tikiwiki.org.

Version: Create show2.tikiwiki.org instance
Ticket ID
5257
Created
Wednesday 28 May, 2014 09:56:29 GMT-0000
LastModif
Thursday 19 June, 2014 16:49:17 GMT-0000

Attachments

 filenamecreatedhitscommentversionfiletype 
No attachments for this item


Keywords

The following is a list of keywords that should serve as hubs for navigation within the Tiki development and should correspond to documentation keywords.

Each feature in Tiki has a wiki page which regroups all the bugs, requests for enhancements, etc. It is somewhat a form of wiki-based project management. You can also express your interest in a feature by adding it to your profile. You can also try out the Dynamic filter.

Accessibility (WAI & 508)
Accounting
Administration
Ajax
Articles & Submissions
Backlinks
Banner
Batch
BigBlueButton audio/video/chat/screensharing
Blog
Bookmark
Browser Compatibility
Calendar
Category
Chat
Comment
Communication Center
Consistency
Contacts Address book
Contact us
Content template
Contribution
Cookie
Copyright
Credits
Custom Home (and Group Home Page)
Database MySQL - MyISAM
Database MySQL - InnoDB
Date and Time
Debugger Console
Directory (of hyperlinks)
Documentation link from Tiki to doc.tiki.org (Help System)
Docs
DogFood
Draw
Dynamic Content
Preferences
Dynamic Variable
External Authentication
FAQ
Featured links
Feeds (RSS)
File Gallery
Forum
Friendship Network (Community)
Group
Help
History
Hotword
HTML Page
i18n (Multilingual, l10n, Babelfish)
Image Gallery
Import-Export
Install
Integrator
Interoperability
Inter-User Messages
InterTiki
jQuery
Kaltura video management
Karma
Live Support
Logs (system & action)
Lost edit protection
Mail-in
Map
Menu
Meta Tag
Missing features
Visual Mapping
Mobile
Mods
Modules
MultiTiki
MyTiki
Newsletter
Notepad
OS independence (Non-Linux, Windows/IIS, Mac, BSD)
Organic Groups (Self-managed Teams)
Packages
Payment
PDF
Performance Speed / Load / Compression / Cache
Permission
Poll
Profiles
Quiz
Rating
Realname
Report
Revision Approval
Scheduler
Score
Search engine optimization (SEO)
Search
Security
Semantic links
Share
Shopping Cart
Shoutbox
Site Identity
Slideshow
Smarty Template
Social Networking
Spam protection (Anti-bot CATPCHA)
Spellcheck
Spreadsheet
Staging and Approval
Stats
Survey
Syntax Highlighter (Codemirror)
Tablesorter
Tags
Task
Tell a Friend, alert + Social Bookmarking
Terms and Conditions
Theme
TikiTests
Timesheet
Token Access
Toolbar (Quicktags)
Tours
Trackers
TRIM
User Administration
User Files
User Menu
Watch
Webmail and Groupmail
WebServices
Wiki History, page rename, etc
Wiki plugins extends basic syntax
Wiki syntax text area, parser, etc
Wiki structure (book and table of content)
Workspace and perspectives
WYSIWTSN
WYSIWYCA
WYSIWYG
XMLRPC
XMPP




Useful Tools