Active Directory domain users are not recognized by TikiWiki

• Patch
• Less than 30-minutes fix

Domain Users are not recognized by TikiWiki when using IIS and Webserver auth against AD.

substr function in tiki-setup_base.php mistakenly removing first char of the login name during substracting domain part. For example "DOMAIN\username" is truncated "sername".

I've fixed the issue with the patch below.

--- tiki-setup_base.php-orig	2009-11-02 14:55:09.000000000 +0000
+++ tiki-setup_base.php	2010-02-12 13:47:20.613776587 +0000
@@ -331,9 +331,9 @@
 	} elseif ($userlib->user_exists(str_replace("\\\\", "\\", $_SERVER['REMOTE_USER']))) {
 		// Check for the domain\username with just one backslash
 		$_SESSION["$user_cookie_site"] = str_replace("\\\\", "\\", $_SERVER['REMOTE_USER']);
-	} elseif ($userlib->user_exists(substr($_SERVER['REMOTE_USER'], strpos($_SERVER['REMOTE_USER'], "\\") + 2))) {
+	} elseif ($userlib->user_exists(substr($_SERVER['REMOTE_USER'], strpos($_SERVER['REMOTE_USER'], "\\") + 1))) {
 		// Check for the username without the domain name
-		$_SESSION["$user_cookie_site"] = substr($_SERVER['REMOTE_USER'], strpos($_SERVER['REMOTE_USER'], "\\") + 2);
+		$_SESSION["$user_cookie_site"] = substr($_SERVER['REMOTE_USER'], strpos($_SERVER['REMOTE_USER'], "\\") + 1);
 	}
 }
 // Check for Shibboleth Login

This bug has been demonstrated on show2.tikiwiki.org

Please demonstrate your bug on show2.tikiwiki.org